Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use golang 1.20 #630

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Use golang 1.20 #630

merged 1 commit into from
Jun 2, 2023

Conversation

ChunyiLyu
Copy link
Contributor

Summary Of Changes

Use golang 1.20

MirahImage
MirahImage approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@MirahImage MirahImage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only changes that are actually required to upgrade to 1.20 are in go.mod and the Dockerfile, as the other changes already matched 1.20. Nonetheless, it seems reasonable to update everywhere.

.github/workflows/build-test-publish.yml
@@ -12,7 +12,7 @@ on:
tags: [ "v*" ]

env:
GO_VERSION: ~1.19 # Require Go 1.19 and above, but lower than Go 2.0.0
GO_VERSION: ~1.20 # Require Go 1.20 and above, but lower than Go 2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should already be using golang 1.20, as ~1.19 matches 1.20

@ChunyiLyu ChunyiLyu merged commit 06d20ca into main Jun 2, 2023
@ChunyiLyu ChunyiLyu deleted the go120 branch June 2, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MirahImage MirahImage MirahImage approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChunyiLyu @MirahImage @vmwclabot